bug: Add missing text field in Administered Medications #122
bug: Add missing text field in Administered Medications #122vochaparro2 wants to merge 5 commits intomainfrom
text field in Administered Medications #122Conversation
…nto laura-victor/1345-dosage-text # Conflicts: # src/Dibbs.Fhir.Liquid.Converter.UnitTests/Templates/eCR/Resource/MedicationAdministrationTests.cs
vochaparro2
requested review from
angelathe and
laura-puerto-skylight
and removed request for
a team
|
Looks good to me! Since I helped with the changes I will let @angelathe approve :) |
| {% if medicationAdministration.text._innerText %} | ||
| "text": "{{ medicationAdministration.text._innerText | clean_string_from_tabs | escape_special_chars }}", | ||
| {% else %} | ||
| "text": "{{ medicationAdministration.text._ | clean_string_from_tabs | escape_special_chars }}", | ||
| {% endif %} |
There was a problem hiding this comment.
Perchance does the following work? (to reduce clutter)
"text": "{{ medicationAdministration.text._innertext | default: medicationAdministration.text._ | clean_string_from_tabs | escape_special_chars }}"
There was a problem hiding this comment.
This had to be updated a lot to support the text reference.
| "start": "1981-10-16T17:31:14Z" | ||
| }, | ||
| "dosage": { | ||
| "text": "<reference value=\"#sig7\" xmlns=\"urn:hl7-org:v3\" />", |
There was a problem hiding this comment.
Ah, I tink this should actually have the #sig7 value. In MedicationAdministration resource, we should also add the case where text has a reference value that we can pull.
medicationAdministration.text.reference._ I think?
- unit test
There was a problem hiding this comment.
It's good that we had a test message formatted this way. It took me a while to figure out how to extract that text. Let me know if there's a better way to handle that, but it makes it hard because the referenced text is at a higher level than the dosage text.
3 participants
Summary
The Medication Administrations mappings were missing a mapping for the
textproperty. The property is now being mapped underMedicationAdministration.dosage.textPR for viewer changes
Related Issue
Fixes #1345
Acceptance Criteria
Additional Information
Anything else the review team should know?
Checklist
dibbs-ecr-viewerPR & checked that things work on the front-end.dibbs-ecr-viewer)dibbs-ecr-viewerPR is created and validated. When both have been approved:dibbs-fhir-converterdibbs-ecr-viewerwith the updated release branch number.